Skip to content

fix: trying to remove an already deleted space permission will success#527

Open
jvillafanez wants to merge 1 commit intomainfrom
space_permission_double_remove
Open

fix: trying to remove an already deleted space permission will success#527
jvillafanez wants to merge 1 commit intomainfrom
space_permission_double_remove

Conversation

@jvillafanez
Copy link
Member

Trying to delete an already deleted permission from a space was causing a 500 error.

The easiest way to reproduce the issue is to resend the delete request that happens when a user is removed from a space. You can use the web developer tools for that.
This can also happen with multiple clients: manager A and manager B see the same space information from web and mobile respectively. They both try to delete a user from a space at the same time. One of them (the second one) will receive the 500 error.

This fix will cause the request to finish with a 204 code, as if the deletion was successful (the user isn't a member of the space anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants