fix: trying to remove an already deleted space permission will success#527
Open
jvillafanez wants to merge 1 commit intomainfrom
Open
fix: trying to remove an already deleted space permission will success#527jvillafanez wants to merge 1 commit intomainfrom
jvillafanez wants to merge 1 commit intomainfrom
Conversation
2403905
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to delete an already deleted permission from a space was causing a 500 error.
The easiest way to reproduce the issue is to resend the delete request that happens when a user is removed from a space. You can use the web developer tools for that.
This can also happen with multiple clients: manager A and manager B see the same space information from web and mobile respectively. They both try to delete a user from a space at the same time. One of them (the second one) will receive the 500 error.
This fix will cause the request to finish with a 204 code, as if the deletion was successful (the user isn't a member of the space anyway).