Skip to content

feat(imessage): support inbound image attachments - #195

Merged
owainlewis merged 6 commits into
mainfrom
codex/189-imessage-images
Aug 4, 2026
Merged

owainlewis merged 6 commits into
mainfrom
codex/189-imessage-images

Conversation

@owainlewis

@owainlewis owainlewis commented Aug 4, 2026 •

Copy link
Copy Markdown
Owner

Closes #189

Summary

  • join ordered iMessage attachment metadata without reading bytes during polling
  • safely load accepted local JPEG, PNG, and WebP images and convert HEIC/HEIF through a private sips workspace
  • defer briefly for pending Messages filenames only after channel acceptance, while rejected and later ready rows continue
  • forward prepared images to Codex, Pi, and Claude while preserving filtering, history, and cursor behavior
  • document formats, limits, privacy, Full Disk Access, and conversion requirements

Security and reliability

  • open the canonical Messages attachment root and every child component with no-follow descriptor traversal
  • verify the anchored root device/inode and reject root-parent, final-file, and escaping-symlink races
  • copy HEIC/HEIF from the validated descriptor with a 32 MiB input bound before invoking sips
  • persist the three-poll filename grace across restarts and keep its cursor barrier through history, queue, and pre-worker failures
  • persist out-of-order completion before advancing the in-memory ACK, retry marker-write failures behind a cursor barrier, and prune markers transactionally
  • consume durable completion markers only from complete iMessage snapshots, in poll order

Verification

  • cargo test --locked imessage (32 passed)
  • cargo test --locked gateway (81 passed)
  • cargo fmt --all --check
  • cargo clippy --locked --all-targets -- -D warnings
  • cargo build --locked
  • cargo test --locked (447 unit tests plus all integration suites)
  • mkdocs build --strict
  • real macOS sips HEIC round-trip test
  • independent implementation and final restart/persistence reviews: approved

Manual Messages delivery was not performed from this development environment.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6cb0428d9a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/imessage/attachments.rs Outdated
@owainlewis

Copy link
Copy Markdown
Owner Author

@codex review

@owainlewis

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f58c140f9d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/imessage/poller.rs Outdated
@owainlewis

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bcce44324a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/imessage/poller.rs Outdated

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 639892c8f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/gateway/mod.rs

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d83e8c9bac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/imessage/poller.rs Outdated

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: f99ef04ced

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@owainlewis
owainlewis merged commit ececc59 into main Aug 4, 2026
6 of 7 checks passed
@owainlewis
owainlewis deleted the codex/189-imessage-images branch August 4, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support inbound iMessage image attachments

1 participant