Base scaffolding for angular integration#6
Open
ChrisCates wants to merge 1 commit intooverwolf:masterfrom
YungGaming:@integration/angular
Open
Base scaffolding for angular integration#6ChrisCates wants to merge 1 commit intooverwolf:masterfrom YungGaming:@integration/angular
ChrisCates wants to merge 1 commit intooverwolf:masterfrom
YungGaming:@integration/angular
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is certainly not the most ideal situation, as it tries to loosely reflect the functionality from the react app.
However, the gulp file uses a
window.componentvariable to determine which component to render on each specific.htmlpage.See Issue #5 to see concerns in regards to this.
If this structure is okay and viable. I will work on reimplementing the same app in the other examples into the Angular one.
Please note that this is not the full integration, and needs approval in order to be fully integrated.