fix: restore a green suite, and repoint URLs at the overwirehq org - #225
Merged
Merged
Conversation
Plan the 2.0 release in docs/ROADMAP-v2.md: SDK 0.2 migration, interactive question/plan/permission UX over inline keyboards, file-checkpoint undo, per-conversation concurrency, a session browser, token-based usage reporting, classic-mode removal, and container/PyPI distribution. Work already covered by open pull requests is listed as out of scope so contributors do not duplicate it. Link it from the docs index and changelog. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019LaezV767Pguhpat9zVyEs
Add the files a contributor-driven project needs that were missing: issue forms (bug, feature, question) that ask for version, mode and logs up front; a pull request template with a hand-testing section; CODEOWNERS; MAINTAINERS.md with roles, a one-week response promise, the label set, and the path to maintainership; and a Contributor Covenant 2.1 code of conduct. Rewrite CONTRIBUTING.md, which still described the project as mid-way through "TODO-7", to cover PR scope rules, the AI-assisted contribution policy, the current source layout, and the review flow. Add Dependabot (weekly for the Claude SDK and Telegram library, monthly grouped otherwise) and restore a Claude Code Review workflow as a read-only first-pass reviewer that also covers fork PRs. Link the new files from the README, docs index and changelog. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019LaezV767Pguhpat9zVyEs
The Homepage, Repository and Documentation entries in pyproject.toml referenced github.com/richardatkinson/claude-code-telegram, a handle that is not the project's. These URLs surface in `pip show` and would become the links on a PyPI listing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019LaezV767Pguhpat9zVyEs
Resolve the CHANGELOG.md conflict by keeping the Unreleased entries from this branch above the 1.6.2 section from main. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019LaezV767Pguhpat9zVyEs
Drop the out-of-scope rows for PRs merged in 1.6.2 (#214, #212, #196, #177, #178, #206), note #220, point the AskUserQuestion and ExitPlanMode items at the GUARDED_TOOLS set that 1.6.2 introduced, and remove the docs/tools.md item that 1.6.2 already fixed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019LaezV767Pguhpat9zVyEs
The repository moved from RichardAtCT to the overwirehq organisation. Update every github.com/<owner>/claude-code-telegram URL across the README, docs, issue templates, SECURITY.md, packaging metadata and the star-history badge. GitHub redirects the old URLs, so this is about having one canonical location rather than about anything breaking. References to @RichardAtCT as a user are left alone: the CODEOWNERS entries and the maintainers table point at a personal account that has not moved. Name the container image path in roadmap item 0.4 now that the organisation exists, so the first published image lands at ghcr.io/overwirehq/claude-code-telegram with no legacy path to keep. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019LaezV767Pguhpat9zVyEs
The security fix for #219 shipped as 1.7.0 rather than 1.6.2, and #217 merged into main. Move M0 from 1.7 to 1.8 so it does not claim a version that is already out, drop #217 from the out-of-scope table and from the prerequisites, and correct the 1.6.2 references left behind by the version rename. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019LaezV767Pguhpat9zVyEs
PR #222 was squash-merged, so main carries this branch's earlier work as a single commit while the branch still holds the originals. Merging main back in reconciles the two and brings in #217 and the #196 lockfile fix, which the branch predated. Every conflict was the squash duplication: the same file added on both sides. Each was resolved to the branch copy, which is main's content plus the overwirehq URL sweep and the 1.7.0 roadmap corrections. Verified by diffing the merged tree against main: only the thirteen documentation files change, and no source or test file is touched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019LaezV767Pguhpat9zVyEs
main is red. test_allowed_tools_none_unaffected_by_approval_filter asserts that allowed_tools is None when DISABLE_TOOL_VALIDATION is set, but 94d764d (#206) changed that value to [] so it matches the list[str] that ClaudeAgentOptions declares. #217 added the test against a base that did not yet carry #206, so neither pull request was red on its own and the failure only appeared once both were merged. The test's intent is sound: the interactive-approval filter must not disturb the tool list when validation is disabled. Only the expected value was stale, so assert [] instead. Rename the test and reword its docstring, since "none" in the name is what made the mismatch easy to miss. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019LaezV767Pguhpat9zVyEs
…owth-8nv2s5 # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #222, which merged before these landed. Three things, all of them consequences of the org move and the 1.7.0 release.
mainis currently red; this fixes it.test_allowed_tools_none_unaffected_by_approval_filterasserts thatallowed_toolsisNonewhenDISABLE_TOOL_VALIDATIONis set, but94d764d(#206) changed that value to[]so it matches thelist[str]thatClaudeAgentOptionsdeclares. #217 added the test against a base that did not yet carry #206, so neither pull request was red on its own and the failure only appeared once both were onmain.[]is the intended value, not the test: the changelog for #206 records the change as deliberate, and two other tests in the same file (test_sdk_integration.py, around lines 807 and 1433) already assertallowed_tools == []anddisallowed_tools == []. Line 689 was the outlier. The test's intent is sound, so only the expected value changes; the test is renamed because "none" in its name is what made the mismatch easy to miss.Repository URLs now point at
overwirehq. Everygithub.com/<owner>/claude-code-telegramURL across the README, setup and development docs,SECURITY.md, the three issue templates,CONTRIBUTING.md, the packaging metadata and the star-history badge. GitHub redirects the old URLs, so this is about having one canonical location rather than about anything breaking. References to@RichardAtCTas a person are deliberately left alone: the sixCODEOWNERSentries and the maintainers table point at a personal account that has not moved.The v2 roadmap is rebased on reality. The security fix for #219 shipped as 1.7.0 rather than 1.6.2, so M0 moves from 1.7 to 1.8 rather than claiming a version that is already out. #217 is dropped from the out-of-scope table and from the prerequisites now that it is merged, and the leftover 1.6.2 references from the version rename are corrected. Item 0.4 now names
ghcr.io/overwirehq/claude-code-telegram, so the first published image lands there with no legacy path to keep.The changelog
Unreleasedentries from #222 are also restored here. The merge that brought 1.7.0 into that branch dropped them during conflict resolution, which left the community files and roadmap shipped with no changelog record.Related issue
None directly. Repairs the interaction between #206 and #217, and follows up #222.
Type of change
How it was tested
make testandmake lintpass locally: 588 passed, 0 failed; black, isort and flake8 cleanmainbefore fixing it, so it is not introduced by this branchmaintouches only the 14 files listed above, with no source file and no revert of feat: interactive Telegram approval for risky tool calls #217 or ci: install from the committed lock instead of regenerating it #224Checklist
mainis red and this is the open branchCHANGELOG.mdhas an entry under[Unreleased]README.md,docs/,SECURITY.md,CONTRIBUTING.md)Still outstanding after this merges
Repository settings a pull request cannot change, carried over from #222:
CLAUDE_CODE_OAUTH_TOKENsecret, or switch the review workflow toANTHROPIC_API_KEY. Until then that workflow fails on its first run.MAINTAINERS.md; GitHub silently drops template labels that do not exist.Worth a separate look: the two pull requests that broke
mainwere each green in isolation. Requiring branches to be up to date withmainbefore merge would have caught it.🤖 Generated with Claude Code
https://claude.ai/code/session_019LaezV767Pguhpat9zVyEs
Generated by Claude Code