Conversation
fdkgenie
commented
Mar 10, 2026
fdkgenie
commented
- Add anthropic_base_url field to Settings class with corresponding property
- Update ClaudeSDKManager to set ANTHROPIC_BASE_URL environment variable
- Add documentation to .env.example, README.md, and docs/configuration.md
- Enables flexible configuration of proxy/enterprise endpoints for Anthropic API
- Add anthropic_base_url field to Settings class with corresponding property - Update ClaudeSDKManager to set ANTHROPIC_BASE_URL environment variable - Add documentation to .env.example, README.md, and docs/configuration.md - Enables flexible configuration of proxy/enterprise endpoints for Anthropic API
- Add ANTHROPIC_MODELS environment variable support (comma-separated list) - Implement /model slash command with inline keyboard UI similar to /repo - Add comprehensive model name mapping system for enterprise/proxy endpoints - Support aliases like cc-opus, cc-sonnet, cc-haiku resolving to full names - Fix tool state conflicts when switching models mid-session by clearing session - Add friendly display names (Opus 4.6, Sonnet 4.6, Haiku 4.5) in UI - Implement proper validation and error handling for model selection - Create complete test suite with 28 passing tests for model mapping - Update SDK integration to resolve aliases before API calls - Fix callback handler audit logging for both cd: and model: prefixes
Add support for multiple approved base directories, allowing projects
to be located in different filesystem locations while maintaining
security boundaries.
Changes:
- Add APPROVED_DIRECTORIES config (comma-separated paths)
- Update SecurityValidator to check against multiple directories
- Update ProjectRegistry to support absolute paths in projects.yaml
- Add effective_approved_directories property to Settings
- Maintain full backward compatibility with single APPROVED_DIRECTORY
Features:
- Projects can now use absolute paths in projects.yaml
- All paths validated against any approved directory
- Security guarantees maintained (path traversal, boundary checks)
- All existing tests pass (67/67)
Configuration example:
APPROVED_DIRECTORY=/path/to/main
APPROVED_DIRECTORIES=/path/to/main,/path/to/other,/path/to/more
Projects example:
- slug: project1
path: relative/path # Relative to APPROVED_DIRECTORY
- slug: project2
path: /absolute/path # Must be in an approved directory
Documentation:
- MULTIPLE_DIRECTORIES.md - Comprehensive guide
- MULTIPLE_DIRECTORIES_IMPLEMENTATION.md - Technical details
- MULTIPLE_DIRECTORIES_SUMMARY_VI.md - Vietnamese summary
- MULTIPLE_DIRECTORIES_QUICK_REFERENCE.md - Quick reference
- PROJECT_THREADS_MODE_GUIDE.md - Project threads explanation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
The base_url feature is useful for proxy/enterprise setups, but this PR has some scope issues:
The base_url feature itself is straightforward and welcome — splitting it out would fast-track the merge. |
Collaborator
|
Thanks for this. I cannot take it as one change. The title says one setting, but the diff is three features across 15 files: the base URL, a 193-line model mapper, and multi-directory access. It also deletes It is also 31 commits behind main and conflicts now. The base URL is the piece I want, and it is the answer to #171, #208 and #210. If you open that on its own against current main I will review it quickly. The model mapper overlaps #160, which I am taking instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.