Skip to content

[JSC] CodeBlock aging: make one full GC after the lease sufficient - #546

Merged
Jarred-Sumner merged 2 commits into
mainfrom
claude/aging-single-pass
Sep 1, 2026
Merged

[JSC] CodeBlock aging: make one full GC after the lease sufficient#546
Jarred-Sumner merged 2 commits into
mainfrom
claude/aging-single-pass

Also drop the cached baseline code of an aged-out optimizing block's …

6b19203
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Sep 1, 2026 in 32m 31s

Code review found 1 important issue

Found 4 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important Source/JavaScriptCore/bytecode/CodeBlock.cpp:2428 The optimizing-JIT branch here is dead: an unmarked DFG/FTL block always satisfies 'shouldJettisonDueToWeakReference()'
🟡 Nit Source/JavaScriptCore/jit/BaselineJITCode.h:112 nit: 'm_ownerWentAwayAt' (and its '<wtf/ApproximateTime.h>' include) is Bun-specific state but is added unconditionally,