Check exceptions between static property builders, in the JSONL parse loop and in the JSONP fast path - #514
Open
robobun wants to merge 1 commit into
Open
Claude / Claude Code Review
completed
Aug 25, 2026 in 17m 24s
Code review found 1 important issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | Source/JavaScriptCore/runtime/Lookup.cpp:74 |
vm.exception() is private — build break in JSObject.cpp and Lookup.cpp |
Annotations
Check failure on line 74 in Source/JavaScriptCore/runtime/Lookup.cpp
claude / Claude Code Review
vm.exception() is private — build break in JSObject.cpp and Lookup.cpp
`VM::exception()` is private (VM.h:1235, inside the `private:` block at 1205–1289) and only reachable through the fixed friend list at VM.h:1396–1407 — neither `setUpStaticFunctionSlot` nor `JSObject` is on it, so this line and the matching call at `Source/JavaScriptCore/runtime/JSObject.cpp:2981` will fail to compile with "'exception' is a private member of 'JSC::VM'". The intent (making the read count as a validator check) is right, but it needs to go through an `ExceptionScope` — e.g.
Loading