Skip to content

Bytecode cache: return null from Encoder::release when the payload allocation fails #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bytecode cache: return null from Encoder::release when the payload allocation fails #512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Source/JavaScriptCore/runtime/CachedTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,12 @@ class Encoder {
}

size_t size = m_baseOffset + m_currentPage->size();
auto buffer = MallocSpan<uint8_t, VMMalloc>::malloc(size);
// The payload is the encoder's largest allocation and the cache is optional: report ENOMEM instead of crashing.
auto buffer = MallocSpan<uint8_t, VMMalloc>::tryMalloc(size);
if (!buffer) {
error = BytecodeCacheError::StandardError(ENOMEM);
return nullptr;
}
auto bufferSpan = buffer.mutableSpan();
for (const auto& page : m_pages)
memcpySpan(consumeSpan(bufferSpan, page.size()), page.span());
Expand Down
Loading