Upgrade to upstream WebKit d81bcc3d833c - #263
Merged
Merged
Claude / Claude Code Review
completed
Jun 30, 2026 in 15m 14s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | Source/WTF/wtf/TinyLRUCache.h:55-72 |
TinyLRUCache copy ctor/assignment call non-const invalidateIterators() on const reference |
Annotations
Check warning on line 72 in Source/WTF/wtf/TinyLRUCache.h
claude / Claude Code Review
TinyLRUCache copy ctor/assignment call non-const invalidateIterators() on const reference
The new copy constructor and copy-assignment operator call `other.invalidateIterators()` on a `const TinyLRUCache&`, but `invalidateIterators()` (line 192) is non-const and writes `m_findResult` (line 236, not `mutable`). Because the class is a template these members are only instantiated on use, so this is a latent compile error: the first caller to copy a `TinyLRUCache` will fail to build with "discards qualifiers". This is upstream code so it should not block this merge, but worth reporting u
Loading