matchAll/replaceAll: clearer wording for non-global RegExp TypeError

[robobun]

Summary

Replaces the awkward double-negative must not be a non-global regular expression with must contain the global (g) flag in the TypeError thrown by String.prototype.matchAll and String.prototype.replaceAll when given a non-global RegExp.

Before

TypeError: String.prototype.matchAll argument must not be a non-global regular expression

After

TypeError: String.prototype.matchAll argument must contain the global (g) flag

Call sites updated

Rebased onto the upstream WebKit upgrade (#263). That upgrade moved matchAll out of builtins/StringPrototype.js (which no longer exists) into C++, so the change now touches seven C++ call sites instead of the original five:

• Source/JavaScriptCore/runtime/StringPrototype.cpp - matchAll fast path + isRegExp slow path
• Source/JavaScriptCore/runtime/StringPrototype.cpp - replaceAll fast path + isRegExp slow path
• Source/JavaScriptCore/dfg/DFGOperations.cpp - replaceAll DFG paths (empty-replacement + two string-replacement operations)

All seven emit identical wording per method.

Fixes oven-sh/bun#30023

[coderabbitai]

Walkthrough

Error messages for String.prototype.matchAll and String.prototype.replaceAll are updated across multiple implementation files. The messages now directly require the global (g) flag instead of using double-negative phrasing.

Changes

Cohort / File(s)	Summary
matchAll error message Source/JavaScriptCore/builtins/StringPrototype.js	Updated String.prototype.matchAll error message to state "must contain the global (g) flag" for non-global RegExp arguments.
replaceAll error messages Source/JavaScriptCore/runtime/StringPrototype.cpp, Source/JavaScriptCore/dfg/DFGOperations.cpp	Updated String.prototype.replaceAll error messages in both C++ runtime and JIT operation handlers to require the global (g) flag instead of using double-negative phrasing.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the change well, but it omits the required bug title, Bugzilla link, reviewed-by line, and commit-message style file list.	Rewrite it to match the template: include bug title, Bugzilla URL, reviewed-by line, bug-fix explanation, and per-file change list.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: updating error message wording for matchAll/replaceAll RegExp validation.
Linked Issues check	✅ Passed	All code changes directly address the linked issue's requirement to replace the double-negative error message with clearer phrasing about the global flag.
Out of Scope Changes check	✅ Passed	All changes are narrowly scoped to updating error message text across four call sites as required; no unrelated or out-of-scope modifications are present.

---

_{Comment @coderabbitai help to get the list of available commands.}