Hide iteration number on idle engine cylinders - #225
Merged
charneykaye merged 1 commit intoJun 30, 2026
Merged
Conversation
The cycle label (#N) was unconditionally rendered even when a cylinder was idle, producing a ghost issue number. Now it only appears when the cylinder is active, done, or errored — matching the existing server-side rendering logic in dashboard-server.ts. Closes #197
Contributor
Author
|
Reviewed code, no issues found. |
1 similar comment
Contributor
Author
|
Reviewed code, no issues found. |
charneykaye
marked this pull request as ready for review
June 30, 2026 20:24
charneykaye
deleted the
vibrator/issue-197-engine-cylinder-should-not-show-a-number
branch
June 30, 2026 20:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Idle cylinders were showing a ghost iteration number (e.g., "Idle #5") because
cycleLabelincylinder-row.tswas computed unconditionally fromcyl.iterationNumber, which retains its value from the last completed cycle even after the cylinder returns to idle.The fix adds the same status guard that already existed in the server-side SSR path (
dashboard-server.ts): the cycle label is now only rendered when the cylinder isactive,done, orerror.Files changed
src/dashboard/components/cylinder-row.ts— addedisDone/isErrorstatus booleans and gatedcycleLabelon(isActive || isDone || isError).Testing
dashboard-storeunit tests pass.dashboard-server.ts, ensuring consistent behavior between SSR and client-side rendering paths.Closes #197