Repository navigation
Margin taps turn a landscape spread's page (Fixes #304) - #322
Open
arimendelow wants to merge 3 commits into
Open
arimendelow wants to merge 3 commits into
arimendelow wants to merge 3 commits into
Conversation
Capped at 88 pt, the iPad spread's turn zone was its 69 pt margin and 19 pt of text, so taps at 7% and 93% of the width (and 90% on the iPad and the unfolded Duo) woke the controls.
…stops at a tap with no verdict
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304
Cause: on a spread, a page's turn zone was its outer quarter capped at 88 pt (#46). On the iPad's 1376 pt spread that cap covers only the 69 pt margin and 19 pt of text. The reviewers' taps at 7% (96 pt) and 93% (1280 pt) fell in the middle zone and toggled the controls; the build 25 log shows
tap: middle at x 1279 of 1376andx 96. The 90% taps on the iPad (1238 pt) and on the unfolded Duo (856 of 951 pt) missed the same way.Fix: on a spread, each page now turns on its whole outer quarter, with no cap: 172 pt on the iPad, 119 pt on the unfolded Duo. A single page keeps the 88 pt cap. The middle of each page still wakes the controls; taps at 30%, 50% and 70% show them in the UI test. This narrows #46's ruling for spreads only. A spread's page turns on its margin plus the outer edge of its text, which is where the reviewers' thumbs land. A tap at 20% of the width (spazz's
edge-zone-tap-0.2) still shows the controls.A tap dropped under a jump's veil is now logged. The other half of the spazz evidence, taps that did nothing and left no log, is split out to #321.
Proof, counted in turns (
MarginTapUITests, iPad Pro 13-inch, fresh open, landscape, 7 margin taps at 93/90/97/93/7/3/7%):MARGINTAPS turned 2 of 7. Only the 97% and 3% taps turned; the rest showed the controls.turned 7 of 7. The three middle taps showed the controls, and none turned.TapZonesTestscovers the 1376, 1100 and 951 pt spreads and the single page. The UI test can't unfold the Duo (see real-unfold.yml).The new test is in the
ipad-taps-restcatch-all, main only.