Skip to content

fix: enhance flutter view controller looking #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vscmaster merged 1 commit into from
Apr 9, 2026
Merged

fix: enhance flutter view controller looking #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 33 additions & 23 deletions ios/ottu_flutter_checkout/Sources/ottu_flutter_checkout/CheckoutPlatformView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ public class CheckoutPlatformView: NSObject, FlutterPlatformView {

private func deinitCheckout() {
guard let pvc = paymentViewController,
let parentVC = UIApplication.shared.delegate?.window??
.rootViewController as? FlutterViewController
let parentVC = findRootViewController() as? FlutterViewController
else { return }

if parentVC.children.contains(pvc) {
Expand Down Expand Up @@ -106,9 +105,7 @@ public class CheckoutPlatformView: NSObject, FlutterPlatformView {

fileprivate func showSdkError() {
Logger.sdk.info("showSdkError")
if let parentVC = UIApplication.shared.delegate?.window??
.rootViewController as? FlutterViewController
{
if let parentVC = findRootViewController() as? FlutterViewController {
let title = NSLocalizedString(
"failed",
bundle: Bundle.module,
Expand Down Expand Up @@ -202,6 +199,7 @@ public class CheckoutPlatformView: NSObject, FlutterPlatformView {
Logger.sdk.info("Get transactionDetails from apiTransactionDetails")
let transactionDetails: TransactionDetails? = try
apiTransactionDetails?.transactionDetails

Logger.sdk.info("setupPreload")
self.checkout = try Checkout(
formsOfPayments: formsOfPayment,
Expand Down Expand Up @@ -229,32 +227,44 @@ public class CheckoutPlatformView: NSObject, FlutterPlatformView {
Logger.sdk.info("tryAttachController")
guard let pvc = self.paymentViewController else { return }

let rootViewController = findRootViewController()
Logger.sdk.info(
"tryAttachController, pvc: \(rootViewController)"
)
if let parentVC = rootViewController as? FlutterViewController {
Logger.sdk.debug("tryAttachController, addChild PVC")
parentVC.addChild(pvc)
_view.addCheckoutView(pvc.view)
pvc.didMove(toParent: parentVC)
Logger.sdk.info("Added to parent!")
} else {
Logger.sdk.info(
"tryAttachController, PVC hasn found, waiting for parent..."
)
DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
self.tryAttachController()
}
}
}

private func findRootViewController() -> UIViewController? {

if let scene = UIApplication.shared.connectedScenes.first
as? UIWindowScene
{
if let window = scene.windows.first(where: { $0.isKeyWindow }) {
let rootViewController = window.rootViewController
Logger.sdk.info(
"tryAttachController, pvc: \(rootViewController)"
return window.rootViewController

} else {
Logger.sdk.error(
"findRootViewController, unable to find window in scene"
)
if let parentVC = rootViewController as? FlutterViewController {
Logger.sdk.debug("tryAttachController, addChild PVC")
parentVC.addChild(pvc)
_view.addCheckoutView(pvc.view)
pvc.didMove(toParent: parentVC)
Logger.sdk.info("Added to parent!")
} else {
Logger.sdk.info(
"tryAttachController, PVC hasn found, waiting for parent..."
)
DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
self.tryAttachController()
}
}
}
} else {
Logger.sdk.error("findRootViewController, connectedScenes is empty")
}
return nil
}

private func getApiTransactionDetails(_ transactionDetails: String)
-> TransactionDetailsResponse?
{
Expand Down