Skip to content

add optional options parameter for duckdb >= 1.5.0#68

Merged
gutzbenj merged 2 commits intomainfrom
fix/duckdb-1-5-0
Mar 18, 2026
Merged

add optional options parameter for duckdb >= 1.5.0#68
gutzbenj merged 2 commits intomainfrom
fix/duckdb-1-5-0

Conversation

@dhaitz
Copy link
Copy Markdown
Collaborator

@dhaitz dhaitz commented Mar 18, 2026

Description

duckdb_databases() in duckdb >1.5.0 returns an options which leads to the following error:

koality/utils.py", line 43, in identify_database_provider
    return DatabaseProvider(**dict(zip(column_names, first, strict=False)))
TypeError: DatabaseProvider.__init__() got an unexpected keyword argument 'options'"

The proposed change fixes this with a new optional parameter for DatabaseProvider.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring
  • Other (please describe):

Related Issues

Checklist

  • I have read the Contributing Guidelines
  • My code follows the project's code style (poe lint passes)
  • I have added tests for my changes
  • All tests pass (poe test)
  • I have updated documentation as needed

Additional Notes

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.69%. Comparing base (3c761a2) to head (b8d909f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   84.68%   84.69%   +0.01%     
==========================================
  Files           7        7              
  Lines        1208     1209       +1     
==========================================
+ Hits         1023     1024       +1     
  Misses        185      185              
Flag Coverage Δ
unittests 84.69% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gutzbenj
Copy link
Copy Markdown
Collaborator

@copilot add changelog entry

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 18, 2026

@gutzbenj I've opened a new pull request, #69, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: gutzbenj <29654631+gutzbenj@users.noreply.github.com>
@gutzbenj gutzbenj merged commit 8963ac6 into main Mar 18, 2026
13 checks passed
@gutzbenj gutzbenj deleted the fix/duckdb-1-5-0 branch March 18, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants