Repository navigation
fix(otterware): calendar grid fills the page, module hooks stay per app - #96
Merged
Merged
Conversation
- Calendar's week, month and agenda views filled only their content width; the page's main is now a column so the grid stretches across the pane. The no-calendars state uses the shared Empty and navigates in-app instead of a full reload. - The rail's spaces, the page title and the header actions called the next app's hooks in the same component instance when switching apps (React's useMemoCache size error); they are keyed per module now. - Calendar connections and Otter Account connections render as settings rows inside their cards instead of bare headings, paragraphs and full-width buttons. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A browser pass over the combined and the standalone Mail profile found three defects.
Calendar grid width. Week, month and agenda only filled their content width (about 470 of 1130 px). The page's
<main>was a row flexbox; it is a column now, so the grid stretches. The no-calendars state uses the sharedEmptyand an in-app navigation to Connections instead of a bare<a>that reloaded the app.Module hooks across apps. Switching apps reused the rail's space buttons, the page title and the header actions for the next module, so React ran another module's hooks in the same instance (
Expected a constant size argument for each invocation of useMemoCache). They are keyed by module id now; eight back-to-back app switches log no errors.Connection settings. Calendar connections (local Google, OAuth client, demo calendars) and Otter Account connections rendered as raw headings, paragraphs and full-width buttons inside their cards. They are
SettingsRows now, matching the rest of Settings.Verified: web typecheck, lint and knip on the changed files, and the flows above in the browser (combined profile with demo calendars and Watch only; standalone Mail rail and flat settings).
🤖 Generated with Claude Code