Repository navigation
test: cover the version and completion paths Codecov flagged - #23
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #22. Codecov flagged 8 uncovered patch lines:
completion.go(3 missing, 3 partial): the walker's early return for a flag that already has a completion, and the two early returns ofcompletePointNames(no--modelflag; a--modelvalue that is not a model ID).internal/buildinfo/buildinfo.go(2 missing):Set.How they are covered now:
TestRegisterKeepsOwnCompletionregisters a completion on a command's flag, runsregisterCompletionsand checks the command's own completion is kept.TestCompletePointNamesWithoutUsableModelcallscompletePointNameson a command without--modeland on one whose--modelis not a number; both offer nothing and no file names.TestSetReplacesLinkTimeValuescallsSetand checksGetreports the values.Tests only, no production code changed; no RELEASE.md entry.
make checkandmake e2epass locally.🤖 Generated with Claude Code