Repository navigation
chore: bump OT Fabric libraries and align the Go floor - #24
Merged
Merged
Conversation
Bump go-sparkplugb v0.3.3 -> v0.3.4 and lower the go line from 1.27.3 to 1.26.0. CI tests Go 1.26 and 1.27, the release workflow is pinned to otfabric/.github v3.6.0, and the README states Go 1.26. TestVersion no longer needs the dependency list in the test binary build information, which Go 1.26 does not record; the e2e test checks that the built binary names go-sparkplugb instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
edge: a rebirth publishes the DBIRTHs in first-birth order (was map order), andRebirthreads device state under the lock (data race fix).go mod tidypulled no othergithub.com/otfabric/go-*module forward.go 1.27.3→go 1.26.0(the organisation floor; nothing needed 1.27). Tidy kept it. README badge and "from source" line updated.go-versionswas["1.27"], now["1.26", "1.27"], the same as the other CLIs, so 1.26 is tested. I did not drop the input to use the go-ci.yml default: that default (["1.23","1.24","1.25","1.26"], filtered to the go.mod floor) would test only 1.26 and lose 1.27.debug.ReadBuildInfo().Depsand failed with "go-sparkplugb is not a dependency" on Go 1.26, whose test binaries record no dependencies (Go 1.27's do). This is probably why the floor was 1.27.3. The test now expects no library part when the test binary has no dependency list, and the e2e test now checks that the built binary names go-sparkplugb inversionandversion --json, so the check moved to the real binary rather than being dropped..github/workflows/release.ymlusesotfabric/.github/.github/workflows/go-binary-release.yml@v3.6.0(was @v3.3.x). That release builds binaries with the newest patch of the Go minor declared in go.mod, not the exact go.mod version. The v3.6.0 tag is about to be published; pull-request CI does not run release.yml, so this PR does not depend on it.Checks
make check(coverage gate 90 %: 100 %) andmake e2e: green with Go 1.27.3.go vet,go test ./...andmake e2ealso green withGOTOOLCHAIN=go1.26.0.sparkplugbctl versionlistsgo-sparkplugb 0.3.4.🤖 Generated with Claude Code