Repository navigation
test: drop the unreachable error branch in buildinfo JSON - #21
Merged
Merged
Conversation
json.Marshal cannot fail for Info, so the panic branch was dead code that Codecov reported as an uncovered patch line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the version alignment PR. Codecov flagged 2 uncovered patch lines in
internal/buildinfo/buildinfo.go: thepanicafterjson.MarshalinInfo.JSON, which cannot run (Info holds only strings and a slice of string structs). The branch is removed; output is unchanged.make checkpasses locally.🤖 Generated with Claude Code