Repository navigation
deps: go-bacnet v0.8.0 - #20
Merged
Merged
Conversation
go-bacnet v0.8.0 receives segments longer than the Max APDU the client advertises (legacy BACpypes sends 1481 octets to a 1476-octet requester), which bacnetctl's commands dropped and timed out on. RELEASE.md v0.7.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps go-bacnet to v0.8.0 (pinned to bacnet-interop v0.14.0: ulbios, legacy BACpypes and bacnet-js peers).
The user-visible change is in the client: segmented answers whose segments are longer than the advertised Max APDU are now received. Legacy BACpypes sends 1481-octet segments to a 1476-octet requester; before, the command timed out. bacnetctl still advertises at most 1476.
go-bacnet's other fix, BVLC-Result routing while a foreign-device registration is pending, does not reach bacnetctl. bacnetctl waits for the registration before it sends a request (
internal/bac/conn.goawaitRegistration).No change to exit codes or JSON output. RELEASE.md has the v0.7.0 section.
Verification:
make check(coverage 94.5%, minimum 85%) andmake e2e.🤖 Generated with Claude Code