Repository navigation
trend: read trend log multiple and event log objects (go-bacnet v0.7.0) - #19
Merged
Merged
Conversation
… v0.7.0) go-bacnet v0.7.0 decodes Log_Buffer records of Trend Log Multiple and Event Log objects, which it refused before (recorded traffic of a PolarSoft and an Automated Logic device). trend prints one value per logged property (kind values) and the event notifications (kind event). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
The simulated device has no backup or restore procedure; it acknowledged START_BACKUP..ABORT_RESTORE. It now answers services/service-request-denied, as go-bacnet v0.7.0's server does and recorded devices without backup support do, and records the request as refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Built on go-bacnet v0.7.0. go-bacnet now decodes the Log_Buffer records of Trend Log Multiple and Event Log objects; it refused them before. The defect was found in recorded traffic of a PolarSoft device and an Automated Logic device (go-bacnet testdata/captures).
trendon a trend log multiple: each record holds one value per logged property (kind"values", JSONvalues). A property the device could not read shows its error code.trendon an event log: each record holds the event notification (kind"event", JSONevent:event_object,event_type,from_state,to_state,notification_class,priority,message).server runis unchanged. It installs the reinitialize hook, so go-bacnet's new refusal of backup states without a hook does not apply.bactest.Logs()adds a trend log multiple and an event log with the recorded record forms.TestTrendreads both as table, text and JSON, with one request and with--all.Test plan
make check(coverage 94.5 %)make sast REPO=bacnetctl REF=capture-validation: no new findings. The 3 earlier findings are a G101 recorded as a false positive, a G101 and a G304, the last two below the threshold.🤖 Generated with Claude Code