Repository navigation
fix(make): mark the commit -dirty for uncommitted changes - #18
Merged
Merged
Conversation
make build injected the bare HEAD SHA, so a build from a tree with changes reported a clean-looking commit, while go build marks it -dirty. The Makefile now appends -dirty on the same test Go uses for vcs.modified (git status --porcelain). Release builds are unchanged: the release workflow sets COMMIT itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make buildinjected the bare HEAD SHA as the commit, so a binary built from a tree with uncommitted changes reported a clean-looking commit, while a plaingo buildmarks it-dirty.The Makefile now appends
-dirtyusing the same test Go uses forvcs.modified(git status --porcelain, so untracked files count too). Outside a git checkout the suffix is empty.COMMITitself.COMMITends in-dirtywith changes, is the plain SHA on a clean tree, and gets-dirtyfrom an untracked file alone. A realmake build(knxctl) printedcommit 20d9f95…from a clean tree andcommit 20d9f95…-dirtyafter an edit.🤖 Generated with Claude Code