Ensure async handling for FilesRedirectHandler calls#84
Open
edan-bainglass wants to merge 1 commit into
Open
Conversation
Jupyter Server 1.1.1 made this async. Though it worked at least at 1.19, in 2.16, this API inconsistency breaks the redirect. Here we simply address the asynchronous nature of the method by awaiting.
Author
|
Hi @oschuett. As part of our continuous upgrades towards JupyterLab (by way of nbclassic first), I ran into this issue. I tested that indeed this PR resolves the issue and restores proper redirection to files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jupyter Server 1.1.1 made this async. Though it worked at least at 1.19, in 2.16, this API inconsistency breaks the redirect. Here we simply address the asynchronous nature of the method by awaiting.
Closes #83