WIP: run bootc-image-builder PXE tests [HMS-11073] - #2635
Draft
achilleas-k wants to merge 3 commits into
Draft
Conversation
Update the derived container to match the docs.
The rootfs.img gets built with an /etc/fstab file for the boot partition and filesystem. This is created by bootc itself because we set up a /boot mount when running 'install to-filesystem', otherwise the installation fails. However the /boot partition isn't relevant for PXE images.
achilleas-k
changed the title
Member
Author
huh |
achilleas-k
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PXE build tests for bootc-image-builder are currently failing when booting the image. The problem seems to be that we create a filesystem layout for
bootc install to-filesystemwith a/bootpartition. This causesbootcto write an/etc/fstabwith the entry for/boot. However, when booting the PXE image, the partition isn't available (or relevant).Removing the
/bootpartition from the PXE rootfs and adding the--boot-mount-spec=""option tobootc install to-filesystemalso didn't work, but I'll have to dig into the details for that one.I'm opening this PR with an added kernel option during the boot test that masks the
boot.mountunit. This works around the issue, causing the test to fail at a later step. I want to see the CI runs for all base images to see if this is consistent.@brlane-rht I think you know the most about this image type. Do you have any ideas for what's best here? Also, I don't know what changed to make this test fail. I assume it was passing when it was first written.