OSAC-3214: configure parking_vnet_name as deployment variable - #313
OSAC-3214: configure parking_vnet_name as deployment variable#313ori-amizur wants to merge 1 commit into
Conversation
Make the parking V-Net name configurable per deployment instead of
hardcoded. Add PARKING_VNET_NAME to the clusterFulfillment instance
group config in the Helm chart, and update the group_var to read it
via lookup('env'), falling back to the previous default
"idle-agents-network" when not set.
Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Ori Amizur <oamizur@redhat.com>
|
@ori-amizur: This pull request references OSAC-3214 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ori-amizur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
🤖 Finished Review · ✅ Success · Started 11:06 AM UTC · Completed 11:16 AM UTC Commit: |
|
Warning Review limit reached
Next review available in: 66 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Looks good to me Labels: PR modifies Helm chart config and Ansible group vars (deployment infrastructure) |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
2 participants
Make the parking V-Net name configurable per deployment instead of hardcoded. Add PARKING_VNET_NAME to the clusterFulfillment instance group config in the Helm chart, and update the group_var to read it via lookup('env'), falling back to the previous default "idle-agents-network" when not set.
Assisted-by: Claude Code noreply@anthropic.com