NO-ISSUE: grant pull-requests:write to ok-to-test-label-cleanup caller

[eliorerz]

Summary

The ok-to-test-label-cleanup.yml caller in this repo has been failing with startup_failure on every run since at least 2026-07-14 — identically across every repo that calls this reusable workflow (fulfillment-service, osac-operator, osac-aap, osac-installer).

Root cause

The reusable workflow (osac-project/osac-test-infra/.github/workflows/ok-to-test-label-cleanup.yml) declares permissions: pull-requests: write at its job level — it needs that to remove the label and post a comment. This caller granted no permissions at all, so its GITHUB_TOKEN was implicitly restricted to none. GitHub refuses to start a job that calls a reusable workflow requesting more permission than the caller itself has:

The nested job 'remove-label' is requesting 'pull-requests: write',
but is only allowed 'pull-requests: none'.

Fix

Explicitly grant pull-requests: write on the calling job, so that scope is available to hand down to the reusable workflow.

Impact

Not a required status check, so this wasn't blocking merges — but it silently defeats the fork-PR safety net this workflow exists for: new commits on an already-ok-to-test-approved fork PR should force a re-approval, and that reset hasn't been happening.

[openshift-ci-robot]

@eliorerz: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

The ok-to-test-label-cleanup.yml caller in this repo has been failing with startup_failure on every run since at least 2026-07-14 — identically across every repo that calls this reusable workflow (fulfillment-service, osac-operator, osac-aap, osac-installer).

Root cause

The reusable workflow (osac-project/osac-test-infra/.github/workflows/ok-to-test-label-cleanup.yml) declares permissions: pull-requests: write at its job level — it needs that to remove the label and post a comment. This caller granted no permissions at all, so its GITHUB_TOKEN was implicitly restricted to none. GitHub refuses to start a job that calls a reusable workflow requesting more permission than the caller itself has:

The nested job 'remove-label' is requesting 'pull-requests: write',
but is only allowed 'pull-requests: none'.

Fix

Explicitly grant pull-requests: write on the calling job, so that scope is available to hand down to the reusable workflow.

Impact

Not a required status check, so this wasn't blocking merges — but it silently defeats the fork-PR safety net this workflow exists for: new commits on an already-ok-to-test-approved fork PR should force a re-approval, and that reset hasn't been happening.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [eliorerz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Warning

Review limit reached

@eliorerz, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 28 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 39f5e684-7f4e-42c6-a95b-c3f6de0cbf88

📥 Commits

Reviewing files that changed from the base of the PR and between d1cf89d and 8183783.

📒 Files selected for processing (1)

• .github/workflows/ok-to-test-label-cleanup.yml

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}