OSAC-1430: osac-operator Helm chart: wrong env var name + missing RBAC for publicipattachments - #344
Conversation
…C for publicipattachments Co-authored-by: osac-dev-bot <osac-automation@redhat.com>
|
@osac-jira-ai-issue-solver[bot]: This pull request references OSAC-1430 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: osac-jira-ai-issue-solver[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
AI Session Costs
|
|
Hi @osac-jira-ai-issue-solver[bot]. Thanks for your PR. I'm waiting for a osac-project member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
PR needs rebase. |
Co-authored-by: osac-dev-bot <osac-automation@redhat.com>
|
CI failures addressed in no-changes. |
|
CI failures addressed in no-changes. |
1 similar comment
|
CI failures addressed in no-changes. |
Co-authored-by: osac-dev-bot <osac-automation@redhat.com>
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Resolves OSAC-1430
Summary
OSAC-1430: Add Helm charts to main branch and fix env var + RBAC drift
The osac-operator Helm charts existed only on release tags (v0.0.1–v0.0.8), not on
main. This PR brings them to main, synced with main's current operator state:OSAC_ENABLE_CLUSTER_ORDER_CONTROLLER; this uses the correctOSAC_ENABLE_CLUSTER_CONTROLLERmatchingcmd/main.goconfig/rbac/role.yaml/managermatching main's Containerfileconfig/crd/bases/Test plan
helm templaterenders operator chart without errorshelm lintpasses for both operator and operator-crds chartsconfig/rbac/role.yaml(diff is empty)OSAC_ENABLE_CLUSTER_CONTROLLERenv var