OSAC-1585: Fix ClusterOrder controller writing observed NodeRequest state to .spec instead of .status

[osac-jira-ai-issue-solver]

Resolves OSAC-1585

Summary

• Fix handleNodePool() writing observed NodePool replica counts to .spec.nodeRequests instead of .status.nodeRequests, which polluted the desired spec with runtime data and could trigger unnecessary re-provisioning
• Add unit tests for handleNodePool() covering creation, update, and edge cases

Test plan

• Unit tests added for handleNodePool() — 5 new test cases
• All 313 controller tests pass
• golangci-lint passes with no new issues
• Manual verification: deploy operator, create ClusterOrder with NodePool, verify .spec.nodeRequests is not modified by the controller

Fixes: OSAC-1585

[openshift-ci-robot]

@osac-jira-ai-issue-solver[bot]: This pull request references OSAC-1585 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Resolves OSAC-1585

Summary

• Fix handleNodePool() writing observed NodePool replica counts to .spec.nodeRequests instead of .status.nodeRequests, which polluted the desired spec with runtime data and could trigger unnecessary re-provisioning
• Add unit tests for handleNodePool() covering creation, update, and edge cases

Test plan

• Unit tests added for handleNodePool() — 5 new test cases
• All 313 controller tests pass
• golangci-lint passes with no new issues
• Manual verification: deploy operator, create ClusterOrder with NodePool, verify .spec.nodeRequests is not modified by the controller

Fixes: OSAC-1585

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[osac-jira-ai-issue-solver]

AI Session Costs

Session	Cost
New ticket	$2.10
Feedback #1	$0.87
Feedback #2	$0.92
Feedback #3	$0.78
Feedback (4) (no changes)	$0.55
Feedback (5) (error)	$0.97
Feedback (5) retry 1 (no changes)	$0.75
Total	$6.94

[openshift-ci]

Hi @osac-jira-ai-issue-solver[bot]. Thanks for your PR.

I'm waiting for a osac-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[osac-jira-ai-issue-solver]

CI failures addressed in no-changes.

[osac-jira-ai-issue-solver]

CI failures addressed in no-changes.

[osac-jira-ai-issue-solver]

CI failures addressed in no-changes.

[vladikr]

Looks good to me. pretty straightforward.

[osac-jira-ai-issue-solver]

In comment, @vladikr said:

Looks good to me. pretty straightforward.

Thanks for the review! No changes needed — approval acknowledged.

[eranco74]

/retest-required

[github-actions]

Re-triggered failed runs:

• E2E VMaaS Full Install (#28881981584)

[eranco74]

/approve
/lgtm
/retest-required

[AlonaKaplan]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan, eranco74, osac-jira-ai-issue-solver[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [eranco74]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vladikr]

/retest

[github-actions]

Re-triggered failed runs:

• E2E VMaaS Full Install (#28881981584)

[eranco74]

/ok-to-test
/retest-required

[github-actions]

Labeled ok-to-test. Re-ran 1 failed run(s).

[eranco74]

/retest-required

[github-actions]

Re-triggered failed runs:

• E2E VMaaS Full Install (#28881981584)

[eliorerz]

This branch is 447 commits behind main (predates charts/operator-crds), which is why the E2E VMaaS run failed with directory base/osac-operator/charts/operator-crds not found. I don't have push access to this fork's branch to rebase it in place, so I opened #405 with the identical change rebased cleanly onto current main. Recommend merging #405 and closing this one.

[osac-jira-ai-issue-solver]

In comment, @eliorerz said:

This branch is 447 commits behind main (predates charts/operator-crds), which is why the E2E VMaaS run failed with directory base/osac-operator/charts/operator-crds not found. I don't have push access to this fork's branch to rebase it in place, so I opened #405 with the identical change rebased cleanly onto current main. Recommend merging #405 and closing this one.

Agreed — this branch is too far behind main. PR #405 has the identical fix rebased onto current main. Recommend merging #405 and closing this PR.