Skip to content

feat: added note about certificate expiry details#2441

Merged
deepakprabhakara merged 4 commits intomasterfrom
feat/saml-cert-expiry
Feb 17, 2026
Merged

feat: added note about certificate expiry details#2441
deepakprabhakara merged 4 commits intomasterfrom
feat/saml-cert-expiry

Conversation

@deepakprabhakara
Copy link
Contributor

Related Issue or Design Document

https://github.com/ory-corp/cloud/pull/10640

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vinckr vinckr changed the title feate: added note about certificate expiry details feat: added note about certificate expiry details Feb 11, 2026
Co-authored-by: Vincent <vincent@ory.sh>
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run make format to pass the CI :)

also please merge this only after the feature is released, thanks

Copy link
Contributor

@unatasha8 unatasha8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does each SAML connection have more than one signing certificate?

Copy link
Contributor

@unatasha8 unatasha8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepakprabhakara deepakprabhakara merged commit 215663e into master Feb 17, 2026
9 checks passed
@deepakprabhakara deepakprabhakara deleted the feat/saml-cert-expiry branch February 17, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream Issue is caused by an upstream dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments