Conversation
Some of the names were mispelled, so I corrected the typos
Categories sorted by Hair, Emotion, then Celebrity, within those categories sorted alphabetically
|
Seeing now that the file changes on Jupyter Notebooks are hard to preview, I can imagine it might be difficult to approve this one. The changes I made were small and only to the naming of the key fields in the |
|
Hi @mathyouf , I really thank you for your tips! I downloaded the files and looked at them. Looks good overall 😊
Thanks, |
This checkpoint file was generated while testing the notebook changes, and was committed unecessarily
|
Hi @orpatashnik, Thanks for the appreciation! I hope I can keep contributing to improved visualization tools for this project, since i'm a GAN researcher myself and want to make it easier to navigate and visualize what's going on.
That was checked-in on accident. I've deleted it now in the latest commit.
I was on the fence about this, because some of the category id's imply that they were trained on truncations of the celebrities name. Examples: Thanks for taking the time to review this PR. 🙂 |
Purpose
To increase the clarity of reading the dropdown menu.
Typos Fixed
Jhonny Depp -> Johnny Depp
hilary clinton -> Hillary Clinton
Naming Standardized
Old Style: Beyonce, hillary clinton, trump
New Style: Beyonce Knowles, Hillary Clinton, Donald Trump
Ordering By Category then Alphabetical
Old Style: Alphabetical (
'Mark Zuckerberg'out of place)['afro', 'angry', 'Beyonce', 'bobcut', 'bowlcut', 'curly hair', 'Hilary Clinton', 'Jhonny Depp', 'mohawk', 'purple hair', 'surprised', 'Taylor Swift', 'trump', 'Mark Zuckerberg']New Style: By Category of Hairstyle, Emotion, then Celebrity Likeness
['afro', 'bobcut', 'bowlcut', 'curly hair', 'mohawk', 'purple hair', 'angry', 'surprised', 'Beyonce Knowles', 'Donald Trump', 'Hillary Clinton', 'Johnny Depp', 'Mark Zuckerberg', 'Taylor Swift']Potential Issue Mitigated
Changing the actual field id's would cause problems with the lookups of the matching
mapper/pretrained/{edit_id}.ptso none of them were changed (includinghilary_clinton)