OCL:Logging: Add logging priority filter to appenders.#70
Conversation
8a1bd81 to
4d3f6ab
Compare
4d3f6ab to
b875c51
Compare
|
Looks good to me. @snrkiwi ? |
|
Supporting setting the threshold per appender is fine, but in reality what I think you really want to do is set the priority on the category(-ies) being logged instead. If this appender has multiple connected categories being logged at a variety of levels, what is the desired result on then setting the Appender's priority level also? Also, that's a non-backwards compatible fix to force setting in startHook(). Are you relying on the "NOTSET" value to not actually filter anything? Also, why set in startHook() and not configureHook()? |
|
Actually?, only log levels cannot address all use cases. Consider following configuration: Without filter property we get the flood of debug messages in console. And this problem does not have good solution. If additivity is disabled ERROR messages from
I agree, it seems better to move |
I do not known if someone uses OCL::Logging. But without analog of
log4cpp::Appender::setTresholdits interface looks incomplete.