Test CI#259
Closed
tessus wants to merge 7 commits into
Closed
Conversation
Except `Directory`, as there's no async-compatible `glob` implementation
This required a little refactor, but the code is now much cleaner, and correctly handles updating the config
Collaborator
Author
|
Ok, I think we have to contact the tarpulin devs. |
Collaborator
Author
|
Closing this again, after figuring out what the issue is. |
Owner
|
Thanks for investigating this! |
Collaborator
Author
|
You're welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing CI
Currently the same as #246
First theory: something is cached on gh and for some reason 246 can't get out of this state
2nd theory: default expiry has to be set explicitly in tests
3rd theory: tarpulin has a side effect