fix(registry): reject unknown config fields to prevent configuration drift#4139
Open
H4ck3r-netizen wants to merge 1 commit into
Open
Conversation
…drift - Add ALLOWED_CONFIG_FIELDS set defining permitted config keys - Add _validate_config() method that rejects unknown fields - register() now validates config before storing agent - Raise UnknownRegistryFieldError with descriptive message on invalid fields - Log rejected fields for audit purposes - Add 7 regression tests covering valid, empty, unknown, stale, and all-allowed cases Fixes orchestration-agent#4055
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4055
The registry config loader was accepting any configuration fields without validation, allowing stale, duplicate, or policy-violating transitions to be committed. This could cause tasks to resolve to unavailable, unauthorized, or incompatible handlers.
Changes
ALLOWED_CONFIG_FIELDSset with all permitted config keys (image, command, args, env, resources, volumes, network, labels, secrets, schedule, retries, timeout, description)_validate_config()method that rejects unknown fields with a clear error messageregister()now validates config before storing the agentUnknownRegistryFieldError(subclass of ValueError) with descriptive message listing unknown and allowed fieldsTesting
pytest tests/test_registry_fields.py -vBounty
This PR addresses the $2k bounty on issue #4055.