fix(middleware): redact Authorization header in structured logs#4134
Open
UGVicV wants to merge 18 commits into
Open
fix(middleware): redact Authorization header in structured logs#4134UGVicV wants to merge 18 commits into
UGVicV wants to merge 18 commits into
Conversation
added 18 commits
May 22, 2026 11:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the issue where the LoggingMiddleware could expose sensitive headers (Authorization, Cookie, X-Api-Key) in structured log output.
Fix
SENSITIVE_HEADERSfrozenset covering: authorization, proxy-authorization, cookie, set-cookie, x-api-key.REDACTED = "***REDACTED***"constant._redact_headers()helper that masks sensitive header values (case-insensitive key matching).LoggingMiddleware.dispatch()to redact headers before logging.logger.error().Verification
Created
tests/test_middleware.pywith 6 regression tests:test_redacts_authorization: Authorization header masked.test_redacts_cookie: Cookie header masked.test_redacts_x_api_key: X-Api-Key header masked.test_preserves_safe_headers: Non-sensitive headers untouched.test_empty_headers: Empty dict works.test_case_insensitive: Mixed case matching works.flake8 src/api/middleware.py tests/test_middleware.py-> Passed (0 errors)Closes #3899.