fix(sdk): handle 204 No Content responses without JSON decoding#4133
Open
H4ck3r-netizen wants to merge 1 commit into
Open
fix(sdk): handle 204 No Content responses without JSON decoding#4133H4ck3r-netizen wants to merge 1 commit into
H4ck3r-netizen wants to merge 1 commit into
Conversation
- Check response status and body length before json.loads in _request - Return empty dict for 204 responses and empty bodies - Add regression tests for 204 handling on delete_agent and stop_agent Fixes orchestration-agent#4086
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4086
The SDK's
OrchestratorClient._requestmethod was attempting to decode an empty body as JSON when the server returns 204 No Content (e.g., ondelete_agentorstop_agent). This caused cleanup automation to fail after the server already completed the action.Changes
resp.status == 204and empty body before callingjson.loads{}for 204 responses and empty bodiestests/test_sdk_client.pyTesting
pytest tests/test_sdk_client.py -vBounty
This PR addresses the $4k bounty on issue #4086.