fix(#136): add neverForLocation option to expo plugin - #137
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136.
Adds a
neverForLocationprop to the Expo config plugin, so Expo apps can reach the native path added in #135 without writing their own manifest mod.neverForLocation: false(default) - no change to the generated manifest.neverForLocation: true-BLUETOOTH_SCANis declared withandroid:usesPermissionFlags="neverForLocation".neverForLocation: trueandtransport: "ble"-ACCESS_FINE_LOCATIONis also capped atmaxSdkVersion="30". It stays uncapped when SoftAP is in play, since Wi-Fi scanning does require location.Also makes
addPermissionmerge attributes onto an existing entry instead of returning early. It was add-only, so if another plugin declaredBLUETOOTH_SCANfirst (react-native-ble-plxdoes) the flag would silently never land, depending on plugin order inapp.json. It only writes attributes it was asked to write.README updated with the new prop. Verified against a real
expo prebuildoutput for theble/softap/bothxneverForLocationmatrix, not just unit-level logic.