Skip to content

fix(desktop): table first column no longer goes dark in light mode #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oratis merged 1 commit into from
Jun 18, 2026
+17 −0
Merged

fix(desktop): table first column no longer goes dark in light mode #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,23 @@ div[class*="hover:bg-black/5"][class*="dark:hover:bg-white/10"]:hover {
.milkdown .editor tr:hover td {
background: var(--mk-bg-hover);
}
/* The imported Nord theme stripes table columns via `:where(td,th):nth-child(odd)`
and flips them (and row borders) to dark under the OS `prefers-color-scheme` —
which clashes when the app theme differs from the OS (e.g. a light document on
a dark Mac → an unreadable dark first column). Re-assert table backgrounds and
borders from OUR theme variables, with specificity (0,3,1) ≥ Nord's (0,3,0) so
tables follow the chosen app theme, not the OS. */
.milkdown .editor :is(td, th):nth-child(odd),
.milkdown .editor :is(td, th):nth-child(even) {
background-color: transparent;
}
.milkdown .editor th:nth-child(odd),
.milkdown .editor th:nth-child(even) {
background-color: var(--mk-bg-elevated);
}
.milkdown .editor table tr {
border-color: var(--mk-border);
}

/* Lists */
.milkdown .editor ul,
Expand Down
Loading