merge: upstream v1.1.10#29
Merged
Merged
Conversation
MINOR bump (free shell tab was a feature addition, PR fujibee#431).
* release: 1.1.10 * chore(release): map the bridge PID hotfix into the 1.1.10 changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.1.10into the forkWhy
Upstream shipped v1.1.10 as a same-day hotfix for a bug in v1.1.9: when the launcher pre-records the spawned bridge's PID before startup,
ensureSingleInstance()could see its own PID in the pidfile and treat it as a competing instance, sending the bridge into a fast restart loop. Environment-dependent (deterministic per machine), reported upstream by a first-time contributor (JulyFaraway). The fix adds a single early-return when the recorded PID matchesprocess.pid.Validation
codex-bridge.js(lifecycle manifest integration, lifecycle owner 不在: 配送役の残置物が 5 層に散らばる (棚卸し + gc/manifest 提案) #8) sit in a different branch ofensureSingleInstance()(the catch block) than upstream's insertion point, and all other touched files (CHANGELOG.md, VERSION, package.json, app/*, cliff.toml, tests/test_codex_bridge.bats) were byte-identical to v1.1.9 on this fork's main, so upstream's changes applied cleanlyensureSingleInstance()to confirm the fork's manifest calls and upstream's new guard coexist correctlytests/test_codex_bridge.bats: 35/35ok, 0 failures — note most cases, including the new Codex monitor bridge enters rapid restart loop with codex-cli 0.144.6 fujibee/agmsg#442 regression test, are skipped in this Windows/Git-Bash sandbox (skip_on_windows/ nochild_process.spawn/ no unix sockets), same known limitation as PR merge: upstream v1.1.9 #28's validationgit diff --check: clean, no conflict markers or whitespace issuesRelated: #22