Skip to content

fix: use native browser and desktop notifications - #305

Merged
orangeboyChen merged 4 commits into
mainfrom
codex/fix-notification-channels
Nov 2, 2026
Merged

orangeboyChen merged 4 commits into
mainfrom
codex/fix-notification-channels

Conversation

@orangeboyChen

Copy link
Copy Markdown
Owner

Summary

  • use native browser notifications only for web clients; remove the in-app toast fallback
  • hide web notification controls when the browser has no Notification API, including Safari-compatible support detection
  • keep desktop notifications on Electron native system notifications, including custom remote backends
  • rename Bark token controls to Bark key, disable the key input until Bark is enabled, and keep Bark testing below the key field
  • separate web and desktop test notification actions
  • add a save button inside the credential expiry notification card

Validation

  • bun run lint
  • bun run typecheck
  • bun run format:check
  • bun run test:coverage (90 files, 1851 tests passed; 95.89% statements, 91.66% branches, 95.92% functions, 96.33% lines)
  • bun run test:patch-branches --base b02acccf0bc76e96f80f0dd1ed16b52fb59cd1f2
  • bunx next build --webpack

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T19:21:21.691212Z 000ef00 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 000ef00666

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/page-shell.tsx Resolved
@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.48%. Comparing base (b02accc) to head (524b186).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files          97       97           
  Lines        8477     8477           
  Branches     2432     2432           
=======================================
  Hits         8179     8179           
  Misses        298      298           
Flag Coverage Δ
unittests 96.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orangeboyChen
orangeboyChen merged commit 6c6eff7 into main Nov 2, 2026
9 checks passed
@orangeboyChen
orangeboyChen deleted the codex/fix-notification-channels branch November 2, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant