Skip to content

fix(desktop): materialize gateway resources before signing - #304

Merged
orangeboyChen merged 2 commits into
mainfrom
fix/release-macos-signing-v2
Oct 29, 2026
Merged

orangeboyChen merged 2 commits into
mainfrom
fix/release-macos-signing-v2

Conversation

@orangeboyChen

Copy link
Copy Markdown
Owner

Summary

  • Materialize traced gateway dependencies while assembling the Electron app so Next.js standalone symlinks are not copied into the macOS bundle.
  • Add CI checks to fail early when gateway resources contain symlinks, before macOS codesign runs.
  • Keep the release workflow's selected-version rebuild support from fix(desktop): restore macOS release signing #303.

The latest release rebuild on main still failed for both macOS architectures with invalid destination for symbolic link in bundle; the failing links were under Contents/Resources/gateway/.next/node_modules.

Validation

  • bun run lint
  • bun run format:check
  • bun run typecheck
  • bun run test:coverage (1851 tests; 96.33% lines, 95.89% statements, 95.92% functions, 91.66% branches)
  • bun run build
  • CSC_IDENTITY_AUTO_DISCOVERY=false bun scripts/build-desktop.ts --mac --arm64 --dir
  • Verified the packaged gateway contains no symlinks
  • Parsed both modified workflow YAML files

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T17:20:27.753716Z e6b27fb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.48%. Comparing base (72100ca) to head (7f1a0d5).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files          97       97           
  Lines        8477     8477           
  Branches     2432     2432           
=======================================
  Hits         8179     8179           
  Misses        298      298           
Flag Coverage Δ
unittests 96.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orangeboyChen
orangeboyChen merged commit b02accc into main Oct 29, 2026
9 checks passed
@orangeboyChen
orangeboyChen deleted the fix/release-macos-signing-v2 branch October 29, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant