Repository navigation
feat: add separate web and desktop expiry notifications - #301
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba8abcb9f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| title: 'CodeBuddy2API 凭据提醒测试', | ||
| }); | ||
|
|
||
| return Response.json({ delivered, message: 'Test notification sent.' }); |
There was a problem hiding this comment.
Report failed test notifications when no subscriber is connected
When the page's EventSource has not connected yet, has been closed, or the browser does not support EventSource, publishCredentialExpiryNotification returns 0, but this route still responds with HTTP 200 and the settings UI treats any 2xx response as success. In those cases the user is told that the test notification was sent even though no notification was delivered; return a failure status (or have the client inspect delivered) when the count is zero.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
=======================================
Coverage 96.47% 96.48%
=======================================
Files 97 97
Lines 8428 8477 +49
Branches 2414 2432 +18
=======================================
+ Hits 8131 8179 +48
- Misses 297 298 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Validation
bun run lintbun run format:checkbun run typecheckbun run test:coveragebun run test:cibun run test:patch-branches --base 0f449262df1019a7acb9aadfa7fac7353b72d39fbunx next build --webpack