Skip to content

feat: add separate web and desktop expiry notifications - #301

Merged
orangeboyChen merged 1 commit into
mainfrom
codex/credential-expiry-web-notifications
Oct 27, 2026
Merged

orangeboyChen merged 1 commit into
mainfrom
codex/credential-expiry-web-notifications

Conversation

@orangeboyChen

Copy link
Copy Markdown
Owner

Summary

  • add separate web browser and desktop native credential expiry notification settings
  • stream expiry events over channel-specific authenticated SSE connections
  • send desktop notifications through Electron IPC, including custom remote backends
  • add channel-specific test notification actions and coverage

Validation

  • bun run lint
  • bun run format:check
  • bun run typecheck
  • bun run test:coverage
  • bun run test:ci
  • bun run test:patch-branches --base 0f449262df1019a7acb9aadfa7fac7353b72d39f
  • bunx next build --webpack

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T18:23:37.732614Z ba8abcb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba8abcb9f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

title: 'CodeBuddy2API 凭据提醒测试',
});

return Response.json({ delivered, message: 'Test notification sent.' });

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Report failed test notifications when no subscriber is connected

When the page's EventSource has not connected yet, has been closed, or the browser does not support EventSource, publishCredentialExpiryNotification returns 0, but this route still responds with HTTP 200 and the settings UI treats any 2xx response as success. In those cases the user is told that the test notification was sent even though no notification was delivered; return a failure status (or have the client inspect delivered) when the count is zero.

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.48%. Comparing base (0f44926) to head (ba8abcb).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   96.47%   96.48%           
=======================================
  Files          97       97           
  Lines        8428     8477   +49     
  Branches     2414     2432   +18     
=======================================
+ Hits         8131     8179   +48     
- Misses        297      298    +1     
Flag Coverage Δ
unittests 96.48% <98.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orangeboyChen
orangeboyChen merged commit 68711cb into main Oct 27, 2026
7 of 8 checks passed
@orangeboyChen
orangeboyChen deleted the codex/credential-expiry-web-notifications branch October 27, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant