Skip to content

Instrument also wrapped PoolDataSource (fixes #350) - #352

Open
fabio-grassi wants to merge 1 commit into
oracle:mainfrom
fabio-grassi:issue-350
Open

fabio-grassi wants to merge 1 commit into
oracle:mainfrom
fabio-grassi:issue-350

Conversation

@fabio-grassi

Copy link
Copy Markdown

Description

This PR proposes to followinf the consolidated Spring Boot practice (see for instance DataSourcePoolMetadataProvidersConfiguration.java), of unwrapping the candidate dataSource and instrument it if of type PoolDataSource.

🔗 Related Issue

Fixes #350

…DataSource.

Signed-off-by: Fabio Grassi <40345396+fabio-grassi@users.noreply.github.com>
@oracle-contributor-agreement

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Oct 8, 2026

@anders-swanson anders-swanson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Let me know if you need help with the OCA.

@fabio-grassi

Copy link
Copy Markdown
Author

This looks good to me. Let me know if you need help with the OCA.

I had filed the OCA yesterday before submitting the PR, I soon received a notification stating that "the document is now pending review with the OCA approvers", let's wait some time and see if it unblocks.

@fabio-grassi fabio-grassi changed the title Instrument also unwrapped data sources provided they are of type PoolDataSource (fixes #350) Instrument also wrapped PoolDataSource (fixes #350) Oct 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ucp-micrometer starter fails to instrument wrapped datasources

2 participants