fix(ai): wire MaxTokens and Temperature through AnalyzerConfig#211
Open
Aashita101 wants to merge 4 commits into
Open
fix(ai): wire MaxTokens and Temperature through AnalyzerConfig#211Aashita101 wants to merge 4 commits into
Aashita101 wants to merge 4 commits into
Conversation
Signed-off-by: Aashita101<aashita.mitblr2025@learner.manipal.edu>
Signed-off-by: Aashita101 <aashita.mitblr2025@learner.manipal.edu>
|
🚀 First PR — welcome aboard! A few things to expect:
If you get stuck, reply here or jump to Discussions. We want this PR to land. |
Signed-off-by: Aashita101 <aashita.mitblr2025@learner.manipal.edu>
Signed-off-by: Aashita101 <aashita.mitblr2025@learner.manipal.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DefaultAnalyzer.Analyzebuilt theCompletionRequestwithoutMaxTokensorTemperature, so configured values were silently ignored and the AI always ran on provider defaults.Why
Fixes #120
How
MaxTokensandTemperaturefields toAnalyzerConfigandDefaultAnalyzerCompletionRequestinsideAnalyzeso per-request values are wired correctlybuildAnalyzerindoctor.gonow passes the configured values throughTesting
go build ./...passesgo test ./...passesgo vet ./...passesgolangci-lint run ./...passesChecklist