Skip to content

fix(ai): wire MaxTokens and Temperature through AnalyzerConfig#211

Open
Aashita101 wants to merge 4 commits into
optiqor:mainfrom
Aashita101:Aashita101-patch-1
Open

fix(ai): wire MaxTokens and Temperature through AnalyzerConfig#211
Aashita101 wants to merge 4 commits into
optiqor:mainfrom
Aashita101:Aashita101-patch-1

Conversation

@Aashita101

Copy link
Copy Markdown

What

DefaultAnalyzer.Analyze built the CompletionRequest without MaxTokens or Temperature, so configured values were silently ignored and the AI always ran on provider defaults.

Why

Fixes #120

How

  • Added MaxTokens and Temperature fields to AnalyzerConfig and DefaultAnalyzer
  • Set them on the CompletionRequest inside Analyze so per-request values are wired correctly
  • buildAnalyzer in doctor.go now passes the configured values through
  • Zero values fall back to provider defaults, keeping existing behaviour intact

Testing

  • go build ./... passes
  • go test ./... passes
  • go vet ./... passes
  • golangci-lint run ./... passes
  • N/A — pure docs/refactor

Checklist

  • PR title follows Conventional Commits
  • All commits are DCO-signed
  • No unrelated changes pulled in
  • Documentation updated where user-visible behavior changed
  • Added/updated tests for new code paths

Signed-off-by: Aashita101<aashita.mitblr2025@learner.manipal.edu>
Signed-off-by: Aashita101 <aashita.mitblr2025@learner.manipal.edu>
@Aashita101 Aashita101 requested a review from btwshivam as a code owner June 9, 2026 14:19
@github-actions github-actions Bot added level:critical Touches BPF, security, or release surfaces (auto-applied) area/integrations External integrations (sinks, exports, CI) and removed level:critical Touches BPF, security, or release surfaces (auto-applied) labels Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

🚀 First PR — welcome aboard!

A few things to expect:

  1. CI: every PR runs build + race tests + lint + (eventually) the kernel matrix. If something fails, the log will tell you exactly which gate.
  2. DCO: every commit needs Signed-off-by:git commit -s adds it automatically.
  3. Conventional Commits: PR titles like feat(doctor): add new rule or fix(bpf): handle X. We squash-merge by default.
  4. Review: a maintainer will review within 72 hours. Suggestions are conversations, not orders — push back if something doesn't fit your context.

If you get stuck, reply here or jump to Discussions. We want this PR to land.

Signed-off-by: Aashita101 <aashita.mitblr2025@learner.manipal.edu>
@github-actions github-actions Bot added the level:critical Touches BPF, security, or release surfaces (auto-applied) label Jun 9, 2026
Signed-off-by: Aashita101 <aashita.mitblr2025@learner.manipal.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/integrations External integrations (sinks, exports, CI) level:critical Touches BPF, security, or release surfaces (auto-applied)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ai): analyzer drops configured max_tokens and temperature

1 participant