test: refactor histogram tests to a table-driven layout#172
Open
anshika07012 wants to merge 1 commit into
Open
test: refactor histogram tests to a table-driven layout#172anshika07012 wants to merge 1 commit into
anshika07012 wants to merge 1 commit into
Conversation
|
🚀 First PR — welcome aboard! A few things to expect:
If you get stuck, reply here or jump to Discussions. We want this PR to land. |
15310ed to
50eb1ee
Compare
50eb1ee to
2708ad9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refactors the sequential log2 bucket math test cases in
histogram_test.gointo a single, clean table-driven layout.Why
Fixes #133
How
TestHistogramTableDrivensuite matching the design style found ininternal/cli/trace_test.go.t.Run()andt.Parallel()to handle subtests concurrently and ensure safe iteration isolation.Merge,Reset, etc.) intact to prevent regressions.Testing
go build ./...passesgo test ./...passesgo vet ./...passesgolangci-lint run ./...passesTested locally with:
go test -vinsideinternal/collector/aggregatorN/A — pure docs/refactor
sudo ./bin/bpf-verify --read 5sconfirms 6/6 programs still load./scripts/verify.shpasses (or specific phase:./scripts/verify.sh quality)Checklist
test(collector): refactor histogram tests to table-driven layout)git commit -s)scripts/verify.sh