net/ndp-proxy-go: Add depend on CARP syshook #5108
Open
+81
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
fichtner
reviewed
Jan 5, 2026
| {% if general.enabled|default("0") == "1" and general.upstream and general.downstream %} | ||
| ndp_proxy_go_enable="YES" | ||
| {% if general.carp_depend_on %} | ||
| start_precmd="ifconfig | grep -q 'carp: MASTER'" |
Member
There was a problem hiding this comment.
can't shake the feeling this was a quick fix I wrote a long time ago but now it's everywhere ;)
Member
Author
There was a problem hiding this comment.
fichtner
reviewed
Jan 5, 2026
| <label>Depend on (CARP)</label> | ||
| <type>checkbox</type> | ||
| <advanced>true</advanced> | ||
| <help>If any CARP VHID on this node is in BACKUP state, the service will be stopped. As NDP is stateless, a short interruption of IPv6 connectivity must be expected during CARP transitions.</help> |
Member
There was a problem hiding this comment.
Code code does "if any VHID is in MASTER state" though ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: opnsense/ports#249
PR: https://forum.opnsense.org/index.php?topic=50157.0