Skip to content

Honor cancellation during basket migration - #5

Merged
rohenaz merged 1 commit into
mainfrom
codex/migration-cancellation
Aug 31, 2026
Merged

Honor cancellation during basket migration#5
rohenaz merged 1 commit into
mainfrom
codex/migration-cancellation

Conversation

@rohenaz

@rohenaz rohenaz commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • check task cancellation before each legacy basket drain page
  • check cancellation before each output internalization
  • prove cancellation stops both loops even when the in-flight dependency ignores cancellation
  • prove a moved page followed by an empty page completes with a nonzero moved count

Verification

  • focused BasketMigrationTests: 9 passed
  • full swift test: 261 passed, 2 skipped

This closes the lock-cancellation gap discovered while reviewing mobile PR #18.

@rohenaz
rohenaz force-pushed the codex/migration-cancellation branch from 4e8e54a to fa16624 Compare August 31, 2026 01:39
@rohenaz
rohenaz merged commit fb3460f into main Aug 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant