Merged
Conversation
myabc
reviewed
Apr 2, 2026
| allow(Time).to receive(:now).and_return(Time.utc(2011, "apr", 4, 20, 15, 1)) | ||
| allow(Date).to receive(:today).and_return(Date.civil(2011, 4, 4)) | ||
| around do |example| | ||
| Timecop.freeze(Time.utc(2011, "apr", 4, 20, 15, 1)) { example.run } |
Contributor
There was a problem hiding this comment.
Rails now provides freeze_time so no need for Timecop.
myabc
force-pushed
the
fix/burndown_spec_with_timecop
branch
from
aa6cdbc to
0b45f52
Compare
myabc
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
N/A
What are you trying to accomplish?
Work in comments in #22605