Skip to content

[#73535] Update "finish" sprint to "complete" sprint#22643

Merged
myabc merged 1 commit intorelease/17.3from
bug/73535-update-finish-sprint-to-complete-sprint
Apr 3, 2026
Merged

[#73535] Update "finish" sprint to "complete" sprint#22643
myabc merged 1 commit intorelease/17.3from
bug/73535-update-finish-sprint-to-complete-sprint

Conversation

@dombesz
Copy link
Copy Markdown
Contributor

@dombesz dombesz commented Apr 2, 2026

Ticket

https://community.openproject.org/work_packages/73535

What are you trying to accomplish?

Rename "finish" to "complete" sprint

What approach did you choose and why?

  • Rename the menu item and the complete sprint button.
  • Dialog names, routes etc are left unaffected.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@myabc myabc requested a review from Copilot April 2, 2026 14:00
@myabc myabc self-requested a review April 2, 2026 14:02
@myabc
Copy link
Copy Markdown
Contributor

myabc commented Apr 2, 2026

@dombesz there are a few specs that still need to be updated.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the user-facing “Finish sprint” / “Close sprint” wording to “Complete sprint” in the Backlogs sprint UI.

Changes:

  • Update Backlogs sprint menu item label from “Finish sprint” to “Complete sprint”.
  • Update finish-sprint dialog submit button label from “Close sprint” to “Complete sprint”.
  • Rename related permission helper method in Sprints::StartContract and update its callers.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
modules/backlogs/spec/support/pages/sprint_planning.rb Updates the page object to click the “Complete sprint” button in the finish-sprint dialog.
modules/backlogs/config/locales/en.yml Renames translation keys and changes EN strings to “Complete sprint”.
modules/backlogs/app/controllers/rb_sprints_controller.rb Switches permission check helper from can_start_or_finish? to can_start_or_complete?.
modules/backlogs/app/contracts/sprints/start_contract.rb Renames permission helper method(s) to “complete” wording.
modules/backlogs/app/components/backlogs/sprint_menu_component.rb Renames predicate to show_complete_sprint_action? and updates permission helper usage.
modules/backlogs/app/components/backlogs/sprint_menu_component.html.erb Updates the sprint action label to the new complete_sprint translation key.
modules/backlogs/app/components/backlogs/finish_sprint_dialog_component.html.erb Uses the new button_complete_sprint translation key for the submit button.

@dombesz dombesz force-pushed the bug/73535-update-finish-sprint-to-complete-sprint branch 2 times, most recently from 2822b79 to 500af1e Compare April 2, 2026 15:12
@myabc myabc requested a review from Copilot April 3, 2026 16:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

@myabc myabc force-pushed the bug/73535-update-finish-sprint-to-complete-sprint branch from 6d15c42 to 533e640 Compare April 3, 2026 17:07
@myabc myabc force-pushed the bug/73535-update-finish-sprint-to-complete-sprint branch from 533e640 to 57f5dd6 Compare April 3, 2026 17:28
@myabc myabc force-pushed the bug/73535-update-finish-sprint-to-complete-sprint branch from 57f5dd6 to 5140086 Compare April 3, 2026 18:08
@myabc myabc merged commit 432b138 into release/17.3 Apr 3, 2026
16 of 17 checks passed
@myabc myabc deleted the bug/73535-update-finish-sprint-to-complete-sprint branch April 3, 2026 18:31
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants