[#73535] Update "finish" sprint to "complete" sprint#22643
Merged
myabc merged 1 commit intorelease/17.3from Apr 3, 2026
Merged
[#73535] Update "finish" sprint to "complete" sprint#22643myabc merged 1 commit intorelease/17.3from
myabc merged 1 commit intorelease/17.3from
Conversation
myabc
approved these changes
Apr 2, 2026
Contributor
|
@dombesz there are a few specs that still need to be updated. |
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the user-facing “Finish sprint” / “Close sprint” wording to “Complete sprint” in the Backlogs sprint UI.
Changes:
- Update Backlogs sprint menu item label from “Finish sprint” to “Complete sprint”.
- Update finish-sprint dialog submit button label from “Close sprint” to “Complete sprint”.
- Rename related permission helper method in
Sprints::StartContractand update its callers.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/backlogs/spec/support/pages/sprint_planning.rb | Updates the page object to click the “Complete sprint” button in the finish-sprint dialog. |
| modules/backlogs/config/locales/en.yml | Renames translation keys and changes EN strings to “Complete sprint”. |
| modules/backlogs/app/controllers/rb_sprints_controller.rb | Switches permission check helper from can_start_or_finish? to can_start_or_complete?. |
| modules/backlogs/app/contracts/sprints/start_contract.rb | Renames permission helper method(s) to “complete” wording. |
| modules/backlogs/app/components/backlogs/sprint_menu_component.rb | Renames predicate to show_complete_sprint_action? and updates permission helper usage. |
| modules/backlogs/app/components/backlogs/sprint_menu_component.html.erb | Updates the sprint action label to the new complete_sprint translation key. |
| modules/backlogs/app/components/backlogs/finish_sprint_dialog_component.html.erb | Uses the new button_complete_sprint translation key for the submit button. |
modules/backlogs/app/components/backlogs/finish_sprint_dialog_component.html.erb
Show resolved
Hide resolved
2822b79 to
500af1e
Compare
6d15c42 to
533e640
Compare
myabc
approved these changes
Apr 3, 2026
533e640 to
57f5dd6
Compare
57f5dd6 to
5140086
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/73535
What are you trying to accomplish?
Rename "finish" to "complete" sprint
What approach did you choose and why?
Merge checklist