hack to resolve base tag conflicting with openapi explorer by not inserting the tag for that page#21060
Closed
hack to resolve base tag conflicting with openapi explorer by not inserting the tag for that page#21060
Conversation
toy
force-pushed
the
overcome-base-tag-hack-2
branch
from
af52475 to
6f58c6f
Compare
…erting the tag for that page openapi explorer uses replaceState (pushState in later versions) with anchor only, but this doesn't work with base tag, as anchor is added to the base url instead of current url. So don't insert the tag on exploror page
toy
force-pushed
the
overcome-base-tag-hack-2
branch
from
6f58c6f to
94c7a85
Compare
Contributor
Author
|
Always better to fix something in an opensource library for everyone (Authress-Engineering/openapi-explorer#292) instead of adding a hack around the problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openapi explorer uses replaceState (pushState in later versions) with anchor only, but this doesn't work with base tag, as anchor is added to the base url instead of current url. So don't insert the tag on exploror page
Alternative to #21061
See also https://community.openproject.org/wp/69113