Fix snapshot build#30
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the snapshot build process for the Operaton Docker images by addressing issues with artifact download URLs and ensuring proper default values for image repository variables. The changes enable snapshot builds to correctly locate and download artifacts from GitHub releases.
Key Changes:
- Fixed snapshot artifact download URL to use dynamic version-based paths instead of hardcoded "early-access" directory
- Added default values for IMAGE_REPO_* environment variables to support both CI and local builds
- Updated GitHub Actions runners to use ubuntu-latest for consistency and future compatibility
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pipeline.sh | Added default values for IMAGE_REPO_OPERATON, IMAGE_REPO_TOMCAT, and IMAGE_REPO_WILDFLY environment variables to enable local and CI builds without explicit configuration |
| download.sh | Fixed snapshot build by changing ARTIFACT_BASE_URL to use ${ARTIFACT_VERSION} variable instead of hardcoded "early-access" path |
| .github/workflows/pull-request-build-test.yml | Updated runner from ubuntu-24.04 to ubuntu-latest for consistency |
| .github/workflows/build-test-and-publish.yml | Updated runners from ubuntu-24.04 to ubuntu-latest across both build-and-test and publish jobs |
| .github/act/build-and-test.sh | Added new script for local testing using the act tool to simulate GitHub Actions workflows |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see PR overview