Skip to content

chore: add dependabot.yml, fix wildfly test#21

Merged
jmaster1985 merged 14 commits into
operaton:mainfrom
jmaster1985:issues/20/dependabot
Jul 3, 2025
Merged

chore: add dependabot.yml, fix wildfly test#21
jmaster1985 merged 14 commits into
operaton:mainfrom
jmaster1985:issues/20/dependabot

Conversation

@jmaster1985
Copy link
Copy Markdown
Collaborator

  • adds dependabot
  • fixes missing wildfly docker-repo URL(s)

Comment thread .github/workflows/build-test-and-publish.yml
Comment thread .github/workflows/build-test-and-publish.yml
@@ -0,0 +1,53 @@
on:
pull_request:
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since dependabot creates new pull requests, maybe it makes sense to test the containers with changes applied by dependabot. therefore this new pipeline is created - currently it only tests the operaton on amd64, since I noticed in the other pipelines that this particular image is always tested. Is it OK like this, or we need to test all three dirstros on both amd64 and arm64 platforms?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be sure that all distros are working on upstream dependency changes, especially when the distro is changing itself. IMO the regular build does this already.
This workflow tests when PRs are created on the operaton-docker repo itself. This is for example when dependencies like the base image is changing. I assume that we do not test all platforms, amd64 is enough. But the different distros could make sense.
I do not expect frequent PRs on this repo, then running 2 more build are not a problem. And we gain some safety.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm including the 3 ditros for testing only on amd64 - about that env variables issue, it seems that it's a security fature from Github, the secrets and environment variables are not exposed when the pipeline is triggered by a fork-repo, it makes sense because so a 3rd uknown fork can read the env vars and secrets by having a new workflow. I used hard-coded values for the repo-urls for testing, because: a) they're anyways fixed b) for container tests which are not pushed, we don't need real repo urls

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a follow up update: here I could enable testing for operaton and tomcat distros on amd64 - the container for wildfly seems to have problems which needs to be addressed separately. I have created the issue #22 to fix that issue

@jmaster1985 jmaster1985 merged commit cde962b into operaton:main Jul 3, 2025
2 checks passed
@jmaster1985 jmaster1985 deleted the issues/20/dependabot branch July 3, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants